-
Notifications
You must be signed in to change notification settings - Fork 103
feat: Set up NGF integration to N1 Console #902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview will be available once build job completes!
|
In NIC, the doc provided both the Helm and Manifests options for deploying. We'd want to do the same for NGF, and also include an option to deploy NGF using |
Co-authored-by: bjee19 <139261241+bjee19@users.noreply.github.com>
Co-authored-by: Alan Dooley <a.dooley@f5.com>
Now that I've re-reviewed the Figma, I need to come up with a new file, probably |
@mjang I noticed this PR has two separate pages for Helm and Manifest configurations. ![]() Is there a reason we are not following the same approach for this documentation? |
NGF integration has different options for NGINX OSS and NGINX Plus. That would have required "tabs within tabs" which don't seem to work with our build. I need to go back and evaluate these docs for consistency. Maybe we should set up two separate pages for NIC integration. |
@mjang thanks for clearing that up and for making the new issue. Lets go ahead with these docs for the release and we can refine them going forward. Great work! |
Co-authored-by: Saylor Berman <s.berman@f5.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm after remaining comments from Saylor are resolved.
Co-authored-by: Saylor Berman <s.berman@f5.com>
### Provision an NGINX data plane | ||
|
||
If you have not already done so, review [Deploy a Gateway for data plane instances]({{< ref "/ngf/install/deploy-data-plane.md" >}}). | ||
|
||
### Verify the Deployment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the Data plane guide you just linked checks for the deployment to be running, I don't think we need the Verify the Deployment
section.
@@ -109,6 +109,10 @@ kubectl apply -f https://raw.githubusercontent.com/nginx/nginx-gateway-fabric/v{ | |||
|
|||
{{</tabs>}} | |||
|
|||
### Provision an NGINX data plane | |||
|
|||
If you have not already done so, review [Deploy a Gateway for data plane instances]({{< ref "/ngf/install/deploy-data-plane.md" >}}). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming they wouldn't have done this, so maybe the preface to the sentence isn't necessary. Instead something like "To deploy the NGINX data plane to connect to the NGINX One Console, follow this guide".
Extensively revised (14 Aug, midday), after extensive discussions with @bjee19 , @sylwang , and @sjberman
Proposed changes
Set up NGF integration into N1 Console.
<!-- in comments -->
to the UI and steps that we're using in that processThe primary build page is here: https://frontdoor-test-docs.nginx.com/previews/docs/902/nginx-one/k8s/add-ngf/
I think there's work to be done w/r/t data plane keys. We have a bunch of different ways to create them
This might close issue 660.
Closes #ISSUE
Checklist
Before merging a pull request, run through this checklist and mark each as complete.
README.md
Footnotes
Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content. ↩